gh-129849: Add tests for Py_tp_bases #143208
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Dec 30, 2025
| return PyType_GetModuleByToken((PyTypeObject *)type, token); | ||
| } | ||
|
|
||
| static PyType_Slot HeapCTypeWithBasesSlotInvalid_slots[] = { |
Member
There was a problem hiding this comment.
I am not sure about the name :)
Technically, it is not invalid right now.
What is invalid is that we fill it with None, not with tuple.
| return -1; | ||
| } | ||
| HeapCTypeWithBasesSlot_slots[0].pfunc = bases; | ||
| PyObject *HeapCTypeWithBasesSlot = PyType_FromSpec(&HeapCTypeWithBasesSlot_spec); |
Member
There was a problem hiding this comment.
This can return NULL in theory, let's add a check for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Py_tp_basesis not tested #129849